Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: reverting keepalived changes after removing dependency in 2.19.1#371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
bejjrajesh wants to merge1 commit intonginx:main
base:main
Choose a base branch
Loading
frombejjrajesh:fix-revert-keepalived-changes

Conversation

bejjrajesh
Copy link
Contributor

Proposed changes

This MR will revert the changes introduced in the MR(#233). We have removed the keepalived dependency on the Nginx Instance Manager.

Solution:Keepalived should be installed by customer manually when setting up the NIM HA availability.

Testing: Reverting to existing working copy only.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

If this PR addresses anissue on GitHub, ensure that you link to it here:

Closes #ISSUE

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read thecontributing guidelines
  • I have signed theF5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere toConventional Commits
  • I have ensured that documentation content adheres tothe style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updatedREADME.md andCHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer toour style guide for guidance about placeholder content.

@bejjrajeshbejjrajesh requested a review froma team as acode ownerApril 4, 2025 16:30
@github-actionsgithub-actionsbot added the documentationImprovements or additions to documentation labelApr 4, 2025
@mjang
Copy link
Contributor

mjang commentedApr 4, 2025
edited
Loading

@bejjrajesh I should have asked this question for#233

  • In our docs, we refer to thekeepalived service forhigh availability.
    • If I understand your intent correctly, with this PR (MR), users in disconnected environments will have to use the high availability doc (if they want HA)

For the record, I'm approving, as this seems to be a straight "revert" from PR#233. But we need to know if there's an impact to our docs.

cc@travisamartin

@JTorreGJTorreG added the product/nimNGINX Instance Manager labelApr 24, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mjangmjangmjang approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@bejjrajeshbejjrajesh

Labels
documentationImprovements or additions to documentationproduct/nimNGINX Instance Manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@bejjrajesh@mjang@JTorreG

[8]ページ先頭

©2009-2025 Movatter.jp