Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork144
Enhance CSV export with safer data handling#222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- Replace manual string concatenation with csv.writer() for RFC 4180 compliance- Update open_file() to use text mode with proper encoding and newline handling- Remove manual quoting from csv_converter() as csv.writer() handles this properlyThis addresses potential data corruption with special characters (commas, quotes,newlines) in network flow data by using Python's standard CSV module insteadof manual string formatting.
aouinizied approved these changesNov 25, 2025
7939a98 intonfstream:master 16 of 23 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Enhancement
csv.writer()forRFC 4180 complianceopen_file()to use text mode with proper encoding and newline handlingcsv_converter()ascsv.writer()handles this properlyThis addressespotential data corruption with special characters (commas, quotes, newlines) in network flow data by using Python's standard CSV module instead of manual string formatting.
Dependency
This enhancement requires importing the
csvmodule, which might be not desired. However, thecsvmodule is part of Python's standard library and has been included since Python 2.3. It is available in all Python versions without any pip installation required.