Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork4.7k
WebAuthn: prefer discoverable credentials with legacy fallback#57140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
swissbit-eis-admin wants to merge1 commit intonextcloud:stable32Choose a base branch
base:stable32
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
WebAuthn: prefer discoverable credentials with legacy fallback#57140
swissbit-eis-admin wants to merge1 commit intonextcloud:stable32fromswissbit-eis:fido2-supprt-discoverable-keys
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- require resident keys/UV for new FIDO2 registrations, but retry without if unsupported- allow username-less login by probing discoverable credentials first, then fall back to the old flow- keep legacy (non-discoverable) registration/login paths working for older authenticators
This was referencedDec 17, 2025
Closed
Contributor
susnux commentedDec 17, 2025
Thank you for your contribution! |
Author
swissbit-eis-admin commentedDec 17, 2025 via email
OK, will do.ThxHubertusVon: Ferdinand Thiessen ***@***.***>Gesendet: Mittwoch, 17. Dezember 2025 13:44An: nextcloud/server ***@***.***>Cc: Hubertus Grobbel ***@***.***>; Author ***@***.***>Betreff: Re: [nextcloud/server] WebAuthn: prefer discoverable credentials with legacy fallback (PR#57140) CAUTION: This email is from an external source! / ACHTUNG: Diese E-Mail kommt von extern![https://avatars.githubusercontent.com/u/1855448?s=20&v=4]susnux left a comment (nextcloud/server#57140)<#57140 (comment)>Thank you for your contribution!Pull requests need to go through the master branch first and then can be backported if needed.So could you change the pull request target to master?-Reply to this email directly, view it on GitHub<#57140 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AZ4BICELBMTB462S6IXMFH34CFFYTAVCNFSM6AAAAACPJ2PYACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMNRVGE4DCOJVGE>.You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>> |
Contributor
p1gp1g commentedDec 17, 2025
Non-discoverable passkeys aren't "legacy", and they are useful when using a hardware tokens with limited number of key slots. Registering a discoverable key should be an explicit action from the user:
|
Author
swissbit-eis-admin commentedDec 17, 2025 via email
OK, I will add a checkbox, no prob.The login method supports both methods anyhow.good idea!Von: S1m ***@***.***>Gesendet: Mittwoch, 17. Dezember 2025 14:04An: nextcloud/server ***@***.***>Cc: Hubertus Grobbel ***@***.***>; Author ***@***.***>Betreff: Re: [nextcloud/server] WebAuthn: prefer discoverable credentials with legacy fallback (PR#57140) CAUTION: This email is from an external source! / ACHTUNG: Diese E-Mail kommt von extern![https://avatars.githubusercontent.com/u/31284753?s=20&v=4]p1gp1g left a comment (nextcloud/server#57140)<#57140 (comment)>Non-discoverable passkeys aren't "legacy", and they are useful when using a hardware tokens with limited number of key slots.Registering a discoverable key should be an explicit action from the user: * there can be 2 buttons, one for the discoverable, another for the non-discoverable * or an input checkbox to use a discoverable or not-Reply to this email directly, view it on GitHub<#57140 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AZ4BICHL6PUG3ILX4ST33LD4CFIDVAVCNFSM6AAAAACPJ2PYACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMNRVGI3DEOJSGQ>.You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>> |
Contributor
p1gp1g commentedDec 17, 2025
With the setting, this is an appreciated feature 👍 (talking as a user). BTW, we still need to fix this issue to get passkey only login:#44342 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
3. to review, feature component)stable32)