NotificationsYou must be signed in to change notification settings
Fork4.7k
Star33.6k

fix(lib): include headers from OC\Template\Template as well in produced HTML#57133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

tcitworld wants to merge1 commit intomaster

base:master

Choose a base branch

fromfix-template-headers-injection

Open

fix(lib): include headers from OC\Template\Template as well in produced HTML#57133

tcitworld wants to merge1 commit intomasterfromfix-template-headers-injection

+1 −1

Conversation

Copy link

Member

tcitworld commentedDec 16, 2025

Otherwise we only take those added through deprecated methodOC_Util::addHeader, not those ofOC\Template\Template::addHeader, which does nothing.

Too complicated to add tests unfortunately.

Checklist

Code isproperly formatted
Sign-off message is added to all commits
Tests (unit,integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)
Labels added where applicable (ex: bug/enhancement,3. to review, feature component)
Milestone added for target branch/version (ex: 32.x forstable32)

fix(lib): include headers from OC\Template\Template as well in produc…

8482302

…ed HTMLOtherwise we only take those added through deprecated method C_Util::addHeader, not those ofOC\Template\Template::addHeader, which does nothingSigned-off-by: Thomas Citharel <tcit@tcit.fr>