Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork4.7k
refactor: Migrate away from \OCP\IDBConnection::insertIfNotExist#57124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Conversation
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
| if ($e->getReason() === Exception::REASON_UNIQUE_CONSTRAINT_VIOLATION) { | ||
| $mountPoint =$tmpMountPointName .'-' .$i; | ||
| $i++; | ||
| continue; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No risk of infinite loop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, but this was already the case before. The sharding tests are running into a timeout on some tests, so that could be related (but I don't see why yet).
A unique index must be used to actually guarantee no duplicates, as this method is not even transaction safe (with READ_COMMITTED)