Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: Update@nextcloud/dialogs to v7.0.0#55726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
susnux merged 4 commits intomasterfromchore/update-dialog-v7
Oct 15, 2025
Merged

Conversation

@susnux
Copy link
Contributor

@susnuxsusnux commentedOct 13, 2025
edited
Loading

Summary

This is the first step towards Vue 3.
As this package is a Vue version agnostic version of dialogs, written in Vue 3.

The huge changes count is related to the.license and.map files...

Checklist

@susnuxsusnux added this to theNextcloud 33 milestoneOct 13, 2025
@susnuxsusnux added 3. to reviewWaiting for reviews dependencies labelsOct 13, 2025
@susnuxsusnuxforce-pushed thechore/update-dialog-v7 branch fromd31966c tobe34bbeCompareOctober 13, 2025 20:57
This is the first step torwards Vue 3.As this package is a Vue version agnostic version of dialogs, written inVue 3.Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnuxsusnuxforce-pushed thechore/update-dialog-v7 branch 2 times, most recently from29c9710 to8ae5a8bCompareOctober 15, 2025 11:57
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnuxsusnux marked this pull request as ready for reviewOctober 15, 2025 12:25
@susnuxsusnux requested review froma team andskjnldsv ascode ownersOctober 15, 2025 12:25
@susnuxsusnux requested review fromnfebe andszaimen and removed request fora teamOctober 15, 2025 12:25
@susnuxsusnuxforce-pushed thechore/update-dialog-v7 branch from8ae5a8b tocc4f830CompareOctober 15, 2025 12:25
@susnuxsusnux requested review fromCarlSchwan andartonge and removed request fora teamOctober 15, 2025 12:25
})

it('Can move a file to its parent folder',()=>{
it.only('Can move a file to its parent folder',()=>{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Forgot to remove it?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

followup:#55791

@susnuxsusnux merged commit65cdf14 intomasterOct 15, 2025
146 of 151 checks passed
@susnuxsusnux deleted the chore/update-dialog-v7 branchOctober 15, 2025 13:51
@max-nextcloud
Copy link
Contributor

It looks like this is breaking text CI. Is it expected that file picker button is not primary anymore?

failed-text-test

@susnux
Copy link
ContributorAuthor

@max-nextcloud no but that test in text is also not very good, you should not rely on class names.
Better to use roles (@testing-library/cypress withcy.findByRole('button', { name: 'Choose a.png' }))

@susnux
Copy link
ContributorAuthor

Fix for the primary regression:#55799

max-nextcloud added a commit that referenced this pull requestOct 18, 2025
In Nextcloud Vue v8 the `type` prop for dialog buttonswas deprecated and replaces with the `variant` prop.In v9 the deprecated props are removed.Use the `variant` prop in the deprecated `OC.dialogs`.This is a follow up for#55726.Signed-off-by: Max <max@nextcloud.com>
@susnuxsusnux mentioned this pull requestOct 22, 2025
6 tasks
@susnux
Copy link
ContributorAuthor

/backport to stable32

backportbot[bot] reacted with thumbs up emojibackportbot[bot] reacted with hooray emoji

susnux pushed a commit that referenced this pull requestDec 16, 2025
In Nextcloud Vue v8 the `type` prop for dialog buttonswas deprecated and replaces with the `variant` prop.In v9 the deprecated props are removed.Use the `variant` prop in the deprecated `OC.dialogs`.This is a follow up for#55726.Signed-off-by: Max <max@nextcloud.com>
susnux pushed a commit that referenced this pull requestDec 17, 2025
In Nextcloud Vue v8 the `type` prop for dialog buttonswas deprecated and replaces with the `variant` prop.In v9 the deprecated props are removed.Use the `variant` prop in the deprecated `OC.dialogs`.This is a follow up for#55726.Signed-off-by: Max <max@nextcloud.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@artongeartongeartonge approved these changes

@CarlSchwanCarlSchwanCarlSchwan approved these changes

@skjnldsvskjnldsvAwaiting requested review from skjnldsvskjnldsv is a code owner

@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-frontend

@szaimenszaimenAwaiting requested review from szaimenszaimen is a code owner automatically assigned from nextcloud/server-frontend

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsdependencies

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

5 participants

@susnux@max-nextcloud@artonge@CarlSchwan

[8]ページ先頭

©2009-2025 Movatter.jp