Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Delay panel rendering#160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dg merged 1 commit intonette:masterfromJanTvrdik:pr/lazy_panel_rendering
May 21, 2016
Merged

Conversation

JanTvrdik
Copy link
Contributor

@JanTvrdikJanTvrdik commentedMay 5, 2016•
edited
Loading

Similarly to how we delay rendering of invisible dumps we should delay rendering of invisible panels and render them the first time they became visible. This is especially important when bar panel contains a lot of HTML (for example query log).

What do you think?

dg and hrach reacted with thumbs up emoji
@dgdgforce-pushed themaster branch 6 times, most recently from7f3fd63 tobbc898eCompareMay 19, 2016 14:17
@JanTvrdikJanTvrdikforce-pushed thepr/lazy_panel_rendering branch from2d53b24 to3552156CompareMay 21, 2016 06:44
@JanTvrdikJanTvrdikforce-pushed thepr/lazy_panel_rendering branch from3552156 to5ee0d72CompareMay 21, 2016 06:47
@JanTvrdik
Copy link
ContributorAuthor

JanTvrdik commentedMay 21, 2016•
edited
Loading

@dg This is now ready to merge from my point of view.

@JanTvrdik
Copy link
ContributorAuthor

JanTvrdik commentedMay 21, 2016•
edited
Loading

It breaks toggle persisting in window-mode, I'll look into it.

It did not work before, so it's fine 😄

@dg
Copy link
Member

dg commentedMay 21, 2016

Great!

@dgdg merged commitc5d2579 intonette:masterMay 21, 2016
@JanTvrdikJanTvrdik deleted the pr/lazy_panel_rendering branchMay 21, 2016 16:16
@adrianbj
Copy link
Contributor

Thanks@JanTvrdik - this is awesome!

@dg
Copy link
Member

dg commentedMay 22, 2016

@JanTvrdik there is problem when panel contains dumps with LIVE => TRUE, it is not inited.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@JanTvrdik@dg@adrianbj
[8]ページ先頭
©2009-2025 Movatter.jp