- Notifications
You must be signed in to change notification settings - Fork88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Test and fix nette/http#15 - Session::configure overrides setHandler set...#18
Conversation
* this commit introduces unit test dependency on redis php extension. Don't know how to avoid it..
| require __DIR__ . '/../bootstrap.php'; | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Here should be some check if redis is present (seehttps://github.com/nette/http/blob/master/tests/Http/Response.setCookie.phpt#L13).
You don't have to install the redis php extension? I didn't know it's installed by default. |
| $factory = new Nette\Http\RequestFactory; | ||
| $session = new Nette\Http\Session($factory->createHttpRequest(), new Nette\Http\Response); | ||
| $session->setOptions(array('save_handler' => 'redis', 'save_path' => 'tcp://127.0.0.1:6379')); //or anything different from default - memcached, memcache, mysql.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What about to use$session->setOptions(array('save_handler' => 'files')) - and test can work without redis.
@lexvjatkin ping, can you rework this? |
0bb4336 to96b498cCompare
...tings
Issue:#15