- Notifications
You must be signed in to change notification settings - Fork70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Compiler::loadDefinitions: allow to get to existing service by class#145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
be48786 to6339d48CompareInteresting. What is your specific use case? |
6339d48 tob592489Comparedg pushed a commit that referenced this pull requestFeb 27, 2017
dg pushed a commit that referenced this pull requestMar 8, 2017
dg reviewedMay 2, 2017
| @@ -257,7 +257,13 @@ public function generateCode(): array | |||
| public static function loadDefinitions(ContainerBuilder $builder, array $services, string $namespace = NULL) | |||
| { | |||
| foreach ($services as $name => $def) { | |||
| if ((string) (int) $name === (string) $name) { | |||
| if (is_string($name) && preg_match('#^@\w*[\\\][\w\\\]+\z#', $name)) { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What about
if (is_int($name)) { ....} elseif (preg_match(....)) { ....}Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it is useful when you want to modify anonymous service in your local.neon