Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

PostgreSQL: Floating point value in scientific notation with trailing zero gets changed #307

Closed
@NTSFka

Description

@NTSFka

Version: 3.2, 3.1.7, 3.1, ...

Bug Description

Row normalizer changes value of floating point value in scientific notation (e.g. 1E-10) with exponent that ends with zeroes. This is only done when PDO driver returns floating point value asstring (PostgreSQL) and not asfloat (MySQL and SQLite3).

Steps To Reproduce

Can be reproduced by adding this code toResultSet.normalizeRow.postgre.phpt.

$res =$connection->query('SELECT CAST(1.2E-10 AS double precision) AS value');Assert::same(['value' =>1.2E-10,], (array)$res->fetch());

It fails with:

Driver: pgsqlFailed: ['value' => 0.12] should be     ... ['value' => 1.2E-10]

Database returns value as'1.2E-10' but row normalizer changes value to'1.2E-1' by removing trailing zeroes.

Problem is caused by first block of handling float and decimal values (fromv3.2):

}elseif ($type === IStructure::FIELD_FLOAT ||$type === IStructure::FIELD_DECIMAL) {if (is_string($value) && ($pos =strpos($value,'.')) !==false) {$value =rtrim(rtrim($pos ===0 ?"0$value" :$value,'0'),'.');}$row[$key] = (float)$value;}...

Expected Behavior

Floating point values shouldn't be changed.

Possible Solution

  1. Remove code that remove trailing zeroes from string representation of floating point values - tests didn't failed.
  2. Modify condition in row normalizer to ignore string in scientific notation.

Before 3.1.5 there was code that returns numeric values that are not possible to represent as floating point as string (if I understand correctly) but that was removed in order to fix#289. In result I see no point of having that code because PHP's cast operator can handle conversion and floating point and decimal values are never returned as string after 3.1.5.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions


      [8]ページ先頭

      ©2009-2025 Movatter.jp