- Notifications
You must be signed in to change notification settings - Fork6.1k
Switch to Debian base for static builds and provide systemd-journal support in them.#19647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Ferroin wants to merge14 commits intonetdata:masterChoose a base branch fromFerroin:debian-static-builder
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
a47318b
tob52583b
CompareHello@Ferroin , I am testing your PR in different scenarios, as you requested, and I observed the following:
systemctl status netdata● netdata.service - infrastructure monitoring and troubleshooting, transformed Loaded: loaded (/lib/systemd/system/netdata.service; enabled; vendor preset: enabled) Active: activating (auto-restart) (Result: signal) since Thu 2025-03-06 02:28:06 UTC; 16s ago Process: 1621 ExecStartPre=/bin/mkdir -p /opt/netdata/var/cache/netdata (code=exited, status=0/SUCCESS) Process: 1622 ExecStartPre=/bin/chown -R netdata /opt/netdata/var/cache/netdata (code=exited, status=0/SUCCESS) Process: 1623 ExecStart=/opt/netdata/usr/sbin/netdata -P /run/netdata/netdata.pid -D (code=killed, signal=ABRT) Main PID: 1623 (code=killed, signal=ABRT) I ran this last test on Debian 10. |
Current versions of elfutils libelf are broken for static linkingbecause they do not correctly include required symbols from elfutilsinternal shared code library (libeu). Fixing this requires patching thesources and building ourselves.
Rebased to pick up the latest changes in the master branch. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Summary
DEBUG_BUILD_INFRA
to a non-empty value when running the build, a failure in the build process will drop to a shell in the container being used for building instead of just dying.Test Plan
This requires extensive manual testing far beyond what I’ve already done.
Things that need specific attention andMUST be tested before merging:
dlopen()
things that may be incompatible between glibc versions and may not exist on musl systems).dlopen()
).dlopen()
, but it does so in a way that appears to work fine across distros).I have not personally tested the first item since I don’t have hardware for it, and I can’t readily test the second item, but I have confirmed that the last three all appear to work on my glibc+systemd Gentoo development system.
Additionally, regular runtime testing is required for a wide variety of platforms.
Manual builds for testing work exactly the same as they do for existing static builds (ensure you have a working Docker or rootless Podman setup, then run
packaging/makeself/build-static.sh <arch>
where<arch>
is the CPu architecture to build for).