Movatterモバイル変換

fix(core): make get() throw for implicitly request-scoped trees#15865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Conversation

Copy link

Contributor

JoeNutt commentedNov 1, 2025

Here’s a concise PR body you can paste:

Treat non-static dependency trees as scoped in get(); instruct consumers to use resolve().

Adds focused tests under NestApplicationContext spec to cover implicit request scope via enhancers.

Closes#15836.

PR Checklist

The commit message follows our guidelines:https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Other... Please describe:

What is the current behavior?

Calling module.get on a class whose dependency tree is implicitly non-static (e.g., due to a request‑scoped pipe/guard) returns a prototype-only instance with undefined injections, rather than throwing. Users don’t get guidance to use resolve().
Issue Number:#15836

What is the new behavior?

module.get now throws InvalidClassScopeException for non-static dependency trees (implicit request scope), instructing users to use resolve(). module.resolve continues to instantiate per-context correctly. Added tests to cover both get (throws) and resolve (works).

Does this PR introduce a breaking change?

Other information

Core change: abstract-instance-resolver.ts (guard in find to also check !wrapperRef.isDependencyTreeStatic()).
Tests: nest-application-context.spec.ts (two specs under “implicit request scope via enhancers”).

fix(core): make get() throw for implicitly request-scoped trees

cc50925

Treat non-static dependency trees as scoped in get(); instruct consumers to use resolve().\n\nAdds focused tests under NestApplicationContext spec to cover implicit request scope via enhancers.\n\nClosesnestjs#15836.