Commitf40adf7

authored

fix(inccommand): do not try to preview an ambiguous command (#18827)

1 parentc632f64 commitf40adf7Copy full SHA for f40adf7

File tree

+11

-2

lines changed

+11

-2

lines changed

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -10133,9 +10133,8 @@ bool cmd_can_preview(char *cmd)`
`10133`	`10133`	`if (ea.cmd=='') {`
`10134`	`10134`	`ea.cmd=skipwhite(ea.cmd+1);`
`10135`	`10135`	`}`
`10136`		`-find_ex_command(&ea,NULL);`
`10137`	`10136`
`10138`		`-if (ea.cmdidx==CMD_SIZE) {`
	`10137`	`+if (find_ex_command(&ea,NULL)==NULL\|\|ea.cmdidx==CMD_SIZE) {`
`10139`	`10138`	`return false;`
`10140`	`10139`	`}elseif (!IS_USER_CMDIDX(ea.cmdidx)) {`
`10141`	`10140`	`// find_ex_command sets the flags for user commands automatically`

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@ local exec_lua = helpers.exec_lua`
`5`	`5`	`localinsert=helpers.insert`
`6`	`6`	`localfeed=helpers.feed`
`7`	`7`	`localcommand=helpers.command`
	`8`	`+localassert_alive=helpers.assert_alive`
`8`	`9`
`9`	`10`	`-- Implements a :Replace command that works like :substitute.`
`10`	`11`	`localsetup_replace_cmd=[[`
`@@ -326,4 +327,13 @@ describe("'inccommand' for user commands", function()`
`326`	`327`	`:.Replace text cats^ \|`
`327`	`328`	`]])`
`328`	`329`	`end)`
	`330`	`+`
	`331`	`+it('does not crash on ambiguous command #18825',function()`
	`332`	`+command('set inccommand=split')`
	`333`	`+command('command Reply echo 1')`
	`334`	`+feed(':R')`
	`335`	`+assert_alive()`
	`336`	`+feed('e')`
	`337`	`+assert_alive()`
	`338`	`+end)`
`329`	`339`	`end)`

Comments

(0)