NotificationsYou must be signed in to change notification settings
Fork6.4k
Star94k

Commitf32fd19

authored

fix(diagnostic): remove buf from cache onBufWipeout (#20099)

Doing so on `BufDelete` has issues: - `BufDelete` is also fired for listed buffers that are made unlisted. - `BufDelete` is not fired for unlisted buffers that are deleted.This means that diagnostics will be lost for a buffer that becomes unlisted.It also means that if an entry exists for an unlisted buffer, deleting thatbuffer later will not remove its entry from the cache (and you may see "Invalidbuffer id" errors when using diagnostic functions if it was wiped).Instead, remove a buffer from the cache if it is wiped out.This means simply `:bd`ing a buffer will not clear its diagnostics now.

1 parentb17c5c3 commitf32fd19Copy full SHA for f32fd19

File tree

2 files changed

+11

-2

lines changed

runtime/lua/vim
- diagnostic.lua
test/functional/lua
- diagnostic_spec.lua

2 files changed

+11

-2

lines changed

`‎runtime/lua/vim/diagnostic.lua‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -47,11 +47,11 @@ local bufnr_and_namespace_cacher_mt = {`
`47`	`47`
`48`	`48`	`localdiagnostic_cache`
`49`	`49`	`do`
`50`		`-localgroup=vim.api.nvim_create_augroup('DiagnosticBufDelete', {})`
	`50`	`+localgroup=vim.api.nvim_create_augroup('DiagnosticBufWipeout', {})`
`51`	`51`	`diagnostic_cache=setmetatable({}, {`
`52`	`52`	`__index=function(t,bufnr)`
`53`	`53`	`assert(bufnr>0,'Invalid buffer number')`
`54`		`-vim.api.nvim_create_autocmd('BufDelete', {`
	`54`	`+vim.api.nvim_create_autocmd('BufWipeout', {`
`55`	`55`	`group=group,`
`56`	`56`	`buffer=bufnr,`
`57`	`57`	`callback=function()`

`‎test/functional/lua/diagnostic_spec.lua‎`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -148,6 +148,15 @@ describe('vim.diagnostic', function()`
`148`	`148`	`vim.cmd('bwipeout!')`
`149`	`149`	`return #vim.diagnostic.get()`
`150`	`150`	`]])`
	`151`	`+eq(2,exec_lua[[`
	`152`	`+ vim.api.nvim_set_current_buf(diagnostic_bufnr)`
	`153`	`+ vim.opt_local.buflisted = false`
	`154`	`+ return #vim.diagnostic.get()`
	`155`	`+]])`
	`156`	`+eq(0,exec_lua[[`
	`157`	`+ vim.cmd('bwipeout!')`
	`158`	`+ return #vim.diagnostic.get()`
	`159`	`+]])`
`151`	`160`	`end)`
`152`	`161`
`153`	`162`	`it('resolves buffer number 0 to the current buffer',function()`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitf32fd19

File tree

2 files changed

2 files changed

`‎runtime/lua/vim/diagnostic.lua‎`

`‎test/functional/lua/diagnostic_spec.lua‎`

0 commit comments