Commit996fc22

authored

fix(lsp): avoid pipe leaks if lsp cmd isn't executable (#19717)

The `onexit` handler isn't called if `uv.spawn` doesn't return a handle.

1 parent8b67f37 commit996fc22Copy full SHA for 996fc22

File tree

-0

lines changed

-0

lines changed

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -340,6 +340,9 @@ local function start(cmd, cmd_args, dispatchers, extra_spawn_params)`
`340`	`340`	`end`
`341`	`341`	`handle,pid=uv.spawn(cmd,spawn_params,onexit)`
`342`	`342`	`ifhandle==nilthen`
	`343`	`+stdin:close()`
	`344`	`+stdout:close()`
	`345`	`+stderr:close()`
`343`	`346`	localmsg=string.format('Spawning language server with cmd: `%s` failed',cmd)
`344`	`347`	`ifstring.match(pid,'ENOENT')then`
`345`	`348`	`msg=msg`

Comments

(0)