Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Simpler. :)#371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

AlvarMarkhester
Copy link

No description provided.

Ahmad-A0 reacted with confused emojiresyfer reacted with eyes emoji
Copy link

@timmparsonstimmparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Very cool solution

@Ahmad-A0
Copy link
Collaborator

Ahmad-A0 commentedJul 8, 2022•
edited
Loading

It's a very nice solution, but it will perform worse on average as creating theSet means you have to iterate through the whole ofnums regardless of if you find duplicates or not. Both solutions are technicallyO(N) though.

@AlvarMarkhester
Copy link
Author

It's a very nice solution, but it will perform worse on average as creating theSet means you have to iterate through the whole ofnums regardless of if you find duplicates or not. Both solutions are technicallyO(N) though.

Thanks for the feedback :)

@Ahmad-A0Ahmad-A0 mentioned this pull requestJul 9, 2022
Copy link
Collaborator

@mitchellirvinmitchellirvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

hi@AlvarMarkhester ! thanks for contributing!

I don't think we should remove the existing solution, as it is likely more intuitive for a new programmer (even though it is more verbose). simpler is not always easier to understand!

you're welcome to add your solution beneath the existing solution, though! it is very elegant

@Ahmad-A0
Copy link
Collaborator

Ahmad-A0 commentedAug 31, 2022•
edited
Loading

I'll close this as stale due to the conflicts, but if you choose to resolve them and edit your solution to meet the new guidelines, I'll merge this in.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timmparsonstimmparsonstimmparsons left review comments

@mitchellirvinmitchellirvinmitchellirvin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@AlvarMarkhester@Ahmad-A0@mitchellirvin@timmparsons
[8]ページ先頭
©2009-2025 Movatter.jp