- Notifications
You must be signed in to change notification settings - Fork2.4k
Create 0523-continuous-subarray-sum.js#2548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Added solution for continuous-subarray-sum in JS.
| */ | ||
| var checkSubarraySum = function(arr, k) { | ||
| let sum = 0; | ||
| const remainderMap = new Map(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Suggestion: Init Map with value
constmap=newMap([[key,value]])
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Initializing map as Suggested.
Initializing Map as suggested.
| if(i - remainderMap.get(sum%k) > 1) { | ||
| return true; | ||
| } | ||
| } else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Suggestion: Avoid else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't know how it would be possible without the else case. But I have removed it and added an if stetment. I also removed the nested if condition. Please have a look. Let me know if I can do better :) Btw, I update the submission link in the initial comment. So we know the newly updated code is correct and submitting. If I forget to update the submission link please let me know.
Trimmed the code.
| var checkSubarraySum = function(arr, k) { | ||
| let sum = 0; | ||
| const remainderMap = new Map([ [0, -1] ]); | ||
| // remainderMap.set(0,-1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Remove dead code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Removed it.
Removing old commented code.
Uh oh!
There was an error while loading.Please reload this page.
Added solution for continuous-subarray-sum in JS.
File(s) Added: 0523-continuous-subarray-sum.js
Language(s) Used: JavaScript
Submission URL:https://leetcode.com/problems/continuous-subarray-sum/submissions/983776897/