- Notifications
You must be signed in to change notification settings - Fork2.4k
Adds solutions for problems 17 & 51 in Kotlin#1605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
technophilist commentedDec 27, 2022
- File(s) Modified:17-Letter-Combinations-of-a-Phone-Number.kt, 51-N-Queens.kt
- Language(s) Used:Kotlin.
- Submission URL:https://leetcode.com/problems/letter-combinations-of-a-phone-number/submissions/862446043/,https://leetcode.com/problems/n-queens/submissions/860468704/
It's been more than a month since I first created this pr. I request someone to have a look at it. |
Hi! There are some conflicts. 51 n-queens already exists in the repo, but you can still contribute for problem 17. Also, there is some conflicting issues with the Readme file. Could you also rename your file to follow the repo naming conventions? For filenames, it's Thanks! |
I've resolved the conflicts in the readme file and removed the solution for N-Queens. |
Thank you very much for your contribution. I changed the filename for you. But in the future please use the naming convention. And apologies that it took so long to review your PR. Thank you. |
If you are doing more Kotlin submissions in the future, please assign me to it and I will take a look ASAP :) |
Thank you. Apologies for not using the correct format. I've been contributing to this repo for quite some time, and I don't remember using leading 0's in the file name and also using all lowercase letters. I've just noticed that the repo follows this convention now. I'll make sure that I follow this naming convention in the future 👍🏻 |
No need to apologise! You are correct, I think neetcode changed it a month ago or so (after you've made this PR!) |