Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Adds solutions for problems 17 & 51 in Kotlin#1605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
a93a merged 7 commits intoneetcode-gh:mainfromtechnophilist:main
Feb 25, 2023

Conversation

technophilist
Copy link
Contributor

@technophilist
Copy link
ContributorAuthor

It's been more than a month since I first created this pr. I request someone to have a look at it.

@a93a
Copy link
Collaborator

Hi!

There are some conflicts. 51 n-queens already exists in the repo, but you can still contribute for problem 17. Also, there is some conflicting issues with the Readme file.

Could you also rename your file to follow the repo naming conventions? For filenames, it's<language>/<problem-number>-name-of-problem.<language-extension> (e.g.java/0001-two-sum.java)

Thanks!

@technophilist
Copy link
ContributorAuthor

I've resolved the conflicts in the readme file and removed the solution for N-Queens.

@a93a
Copy link
Collaborator

Thank you very much for your contribution. I changed the filename for you. But in the future please use the naming convention. And apologies that it took so long to review your PR. Thank you.

@a93aa93a merged commit919331c intoneetcode-gh:mainFeb 25, 2023
@a93a
Copy link
Collaborator

If you are doing more Kotlin submissions in the future, please assign me to it and I will take a look ASAP :)

technophilist reacted with thumbs up emoji

@technophilist
Copy link
ContributorAuthor

Thank you very much for your contribution. I changed the filename for you. But in the future please use the naming convention. And apologies that it took so long to review your PR. Thank you.

Thank you. Apologies for not using the correct format. I've been contributing to this repo for quite some time, and I don't remember using leading 0's in the file name and also using all lowercase letters. I've just noticed that the repo follows this convention now. I'll make sure that I follow this naming convention in the future 👍🏻

a93a reacted with thumbs up emoji

@a93a
Copy link
Collaborator

No need to apologise! You are correct, I think neetcode changed it a month ago or so (after you've made this PR!)

technophilist reacted with thumbs up emojitechnophilist reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@technophilist@a93a@Ahmad-A0

[8]ページ先頭

©2009-2025 Movatter.jp