Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

(2.14) Repeating schedule on an interval#7504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
MauriceVanVeen wants to merge1 commit intomain
base:main
Choose a base branch
Loading
frommaurice/schedule-interval

Conversation

@MauriceVanVeen
Copy link
Member

Supports a repeating schedule on an interval as described inADR-51.

A schedule like@every 1s will publish a message every second. A schedule can't run more quickly than once a second. For the case where the server has been down for a minute and it comes back up, it will not immediately trigger/spam 60 events. Instead it will only trigger once and continue on the same interval.

Signed-off-by: Maurice van Veengithub@mauricevanveen.com

@MauriceVanVeenMauriceVanVeen requested a review froma team as acode ownerNovember 3, 2025 12:50
Copy link
Member

@neilalexanderneilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM but please add a test to show what happens when the message containing the schedule is deleted, aged out, purged etc.

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen
Copy link
MemberAuthor

LGTM but please add a test to show what happens when the message containing the schedule is deleted, aged out, purged etc.

Extended the test (TestJetStreamClusterScheduledIntervalMessage) to confirm the scheduling stops when the scheduling subject is removed. Other pre-existing tests already check for other cases, like "overwriting" a schedule by publishing a different schedule for a given subject.

Purging and aging out isn't explicitly tested I don't think, but probably doesn't need to be as the schedule itself needs to exist (be loaded from the store) in order for a message to be scheduled, if it doesn't exist (removed by any means) it's deactivated and removed from the hash wheel.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@neilalexanderneilalexanderneilalexander left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MauriceVanVeen@neilalexander

[8]ページ先頭

©2009-2025 Movatter.jp