Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add support for error headers in auth callout handlers#7500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
istvan-andrasi wants to merge1 commit intonats-io:main
base:main
Choose a base branch
Loading
fromistvan-andrasi:main

Conversation

@istvan-andrasi
Copy link
Contributor

@istvan-andrasiistvan-andrasi commentedOct 31, 2025•
edited
Loading

Signed-off-by: Andrási Istvánisiandrasi@gmail.com
Resolves#7501

Signed-off-by: Andrási István <isiandrasi@gmail.com>
Copy link
Member

@neilalexanderneilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM principally but would like@aricart to take a look too.

Also wondering if we should update theAuth Callouts ADR.

@ripienaar
Copy link
Contributor

All significant content the server react on from the auth callout service must be signed and verifiable imo. If your service can't sign then thats something to log in the service logs. Conceptually I am not sure we can just start acting on unsigned/unverifiable information here

@istvan-andrasi
Copy link
ContributorAuthor

Since it's just a small QoL improvement for the callout service developer, if it raises concerns on the server side, it's probably not worth it.

@ripienaar
Copy link
Contributor

For background when we added the error feedback in the JWT my actual feature request was to have a header the server would just log - essentially exactly this.

But at the time we got the current behaviour instead for the reasons I mentioned :)

istvan-andrasi reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@neilalexanderneilalexanderneilalexander left review comments

@aricartaricartAwaiting requested review from aricart

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for error headers in auth callout handlers

3 participants

@istvan-andrasi@ripienaar@neilalexander
[8]ページ先頭
©2009-2025 Movatter.jp