Fixed matching of the markup and the result#225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

Piterden wants to merge1 commit intonativescript-vue:masterfromPiterden:patch-1

Closed

Fixed matching of the markup and the result#225

Piterden wants to merge1 commit intonativescript-vue:masterfromPiterden:patch-1

Conversation

Copy link

Piterden commentedOct 29, 2018

No description provided.

Fixed matching of the markup and the result

f7cc893

Copy link

nativescript-vue-bot commentedOct 29, 2018

Deploy preview fornativescript-vue ready!

Built with commitf7cc893

https://deploy-preview-225--nativescript-vue.netlify.com

Copy link

Member

rigor789 commentedNov 6, 2018

I feel like this is too verbose as an example. We could add v-for which would be a tad bit better, but still not perfect as it includes more advanced markup. Maybe we could update the screenshot with shorter code.

Copy link

Author

Piterden commentedNov 6, 2018

But it is exactly that code, which result we see on the screenshot.

Copy link

Member

rigor789 commentedNov 8, 2018

@Piterden yes it is the code for the screenshot, but for documentation purposes it is way too verbose. I'm thinking we need to change both the sample code, and the screenshot to be the same, but shorter than the current one.