Add Events Header to StackLayout#213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

AngeloAnolin wants to merge1 commit intonativescript-vue:masterfromAngeloAnolin:patch-1

Closed

Add Events Header to StackLayout#213

AngeloAnolin wants to merge1 commit intonativescript-vue:masterfromAngeloAnolin:patch-1

Conversation

Copy link

AngeloAnolin commentedOct 19, 2018

Some events or methods need to be defined for the control as some of them are not documented in the api reference (https://docs.nativescript.org/api-reference/classes/_ui_layouts_stack_layout_.stacklayout). This will help developers know what events are available for this control where they could wire up some code.

Add events header

d8540dd

Some events or methods need to be defined for the control as some of them are not documented in the api reference (https://docs.nativescript.org/api-reference/classes/_ui_layouts_stack_layout_.stacklayout). This will help developers know what events are available for this control where they could wire up some code.

Copy link

nativescript-vue-bot commentedOct 19, 2018

Deploy preview fornativescript-vue ready!

Built with commitd8540dd

https://deploy-preview-213--nativescript-vue.netlify.com

Copy link

Member

rigor789 commentedOct 20, 2018

Hi@AngeloAnolin, thanks for the PR!

The reason we are not listing all the events is because there are many that are inherited fromViewBase/View. I would rather include information about event inheritance, and how to look for them than to list all possible events likedoubleTap, longPress, swipe, pan, pinch, loaded, and more... and then add them to every element in the docs - which I don't think is a good idea.

I will keep this open as a reminder to add more information about the even inheritance, but I will not be merging it.

ikoevska reviewed

Nov 5, 2018

View reviewed changes

content/docs/en/elements/layouts/stack-layout.md

		## Events
		\| Name \| Description \|
		\|------\|-------------\|
		`tap` \| Emitted when the layout is tapped.

Copy link

Contributor

ikoevskaNov 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	`tap` \| Emitted when the layout is tapped.
	\|`tap`\| Emitted when the layout is tapped.\|

Copy link

Contributor

ikoevska commentedNov 5, 2018

Hi@AngeloAnolin, thanks for the PR!
The reason we are not listing all the events is because there are many that are inherited fromViewBase/View. I would rather include information about event inheritance, and how to look for them than to list all possible events likedoubleTap, longPress, swipe, pan, pinch, loaded, and more... and then add them to every element in the docs - which I don't think is a good idea.
I will keep this open as a reminder to add more information about the even inheritance, but I will not be merging it.

@rigor789 it might make more sense to create an issue about adding event inheritance docs? This will let us close this one.