Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork245
Ensure that a unique, serialized key is only created once per navigateTo#818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
tylerflint wants to merge1 commit intonativescript-vue:masterfromtylerflint:fix-navigateTo-double-render
Closed
Ensure that a unique, serialized key is only created once per navigateTo#818
tylerflint wants to merge1 commit intonativescript-vue:masterfromtylerflint:fix-navigateTo-double-render
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…eTo page, even when render is called multiple times
Thanks - this is a nice find! I actually just merged a similar fix:#814 so I'll close this one. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
navigateTo, there are certain conditions which can force therender()function of thenavEntryInstanceto be called multiple times. The problem is that a key is generated during the render function, and the key generation function has a global incrementing counter. When this occurs, a new navEntryItem is created, which the frame seems to dump promptly, or Vue ignores.To be honest I haven't delved deeply into the inner working of the frame, or really understood how the render function gets called multiple times. Regardless, it does and ensuring that a unique key is only generated once will keep Vue happy.