Fix #809 incorrect ViewNode prev and next siblings after appendChild/insertBefore#811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

rigor789 merged 4 commits intonativescript-vue:masterfromYellowbox-AU:fix-809-ViewNode-siblings-2

Mar 10, 2021

Merged

Fix #809 incorrect ViewNode prev and next siblings after appendChild/insertBefore#811

rigor789 merged 4 commits intonativescript-vue:masterfromYellowbox-AU:fix-809-ViewNode-siblings-2

Mar 10, 2021

Conversation

Copy link

Contributor

delaneyb commentedMar 5, 2021

Fixes#809

delaneyb added3 commits

March 5, 2021 15:44

chore: remove unnecessary check from appendChild

f622ddd

fix: remove node before appending if already a child

b8d1141

fix: set nextSibling of prevSibling upon insertion (fixed)

b46498c

delaneyb mentioned this pull request

Mar 5, 2021

Fix 809 view node siblings#810

Closed

Copy link

Member

rigor789 commentedMar 9, 2021

Nice find@delaneyb! Could you add a test similar to this

nativescript-vue/__tests__/renderer/ViewNode.test.js

Lines 106 to 121 inb46498c

	test('insertBefore sets the correct node relations',()=>{
	letnode=newViewNode()
	letchildNode=newViewNode()
	letrefNode=newViewNode()
	node.childNodes=[refNode]
	refNode.parentNode=node

	node.insertBefore(childNode,refNode)

	expect(node.childNodes.length).toBe(2)
	expect(childNode.parentNode).toEqual(node)
	expect(childNode.prevSibling).toBeFalsy()
	expect(childNode.nextSibling).toEqual(refNode)
	expect(refNode.prevSibling).toEqual(childNode)
	expect(refNode.nextSibling).toBeFalsy()
	})

to assert thechildNode.prevSibling.nextSibling is set? I can do it a bit later as well, so no problem if you can't - will try to get to merging/releasing a patch sometime this week.