Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

build(deps): bump socket.io from 2.3.0 to 2.4.1 in /samples#783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabotdependabotbot commented on behalf ofgithubJan 21, 2021

Bumpssocket.io from 2.3.0 to 2.4.1.

Release notes

Sourced fromsocket.io's releases.

2.4.1

This release reverts the breaking change introduced in2.4.0 (socketio/socket.io@f78a575).

If you are using Socket.IO v2, you should explicitly allow/disallow cross-origin requests:

  • without CORS (server and client are served from the same domain):
io.origins((req,callback)=>{callback(null,req.headers.origin===undefined);// cross-origin requests will not be allowed});
  • with CORS (server and client are served from distinct domains):
io.origins(["http://localhost:3000"]);// for local developmentio.origins(["https://example.com"]);

In any case, please consider upgrading to Socket.IO v3, where this security issue is now fixed (CORS is disabled by default).

Reverts

  • fix(security): do not allow all origins by default (a169050)

Links:

2.4.0

Related blog post:https://socket.io/blog/socket-io-2-4-0/

Features (from Engine.IO)

  • add support for all cookie options (19cc582)
  • disable perMessageDeflate by default (5ad2736)

Bug Fixes

  • security: do not allow all origins by default (f78a575)
  • properly overwrite the query sent in the handshake (d33a619)

⚠️BREAKING CHANGE⚠️

Previously, CORS was enabled by default, which meant that a Socket.IO server sent the necessary CORS headers (Access-Control-Allow-xxx) toany domain. This will not be the case anymore, and you now have to explicitly enable it.

... (truncated)

Changelog

Sourced fromsocket.io's changelog.

2.4.1 (2021-01-07)

Reverts

  • fix(security): do not allow all origins by default (a169050)

2.4.0 (2021-01-04)

Bug Fixes

  • security: do not allow all origins by default (f78a575)
  • properly overwrite the query sent in the handshake (d33a619)
Commits
  • e6b8697 chore(release): 2.4.1
  • a169050 revert: fix(security): do not allow all origins by default
  • 873fdc5 chore(release): 2.4.0
  • f78a575 fix(security): do not allow all origins by default
  • d33a619 fix: properly overwrite the query sent in the handshake
  • 3951a79 chore: bump engine.io version
  • 6fa026f ci: migrate to GitHub Actions
  • See full diff incompare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting@dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from theSecurity Alerts page.

@dependabotdependabotbot added the dependenciesPull requests that update a dependency file labelJan 21, 2021
@codecov-io
Copy link

Codecov Report

Merging#783 (e16f106) intomaster (517ca0a) willnot change coverage.
The diff coverage isn/a.

Impacted file tree graph

@@           Coverage Diff           @@##           master     #783   +/-   ##=======================================  Coverage   14.63%   14.63%           =======================================  Files          46       46             Lines        1237     1237             Branches      306      306           =======================================  Hits          181      181             Misses        826      826             Partials      230      230

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update517ca0a...e16f106. Read thecomment docs.

@rigor789rigor789 merged commit5631e27 intomasterMar 10, 2021
@dependabotdependabotbot deleted the dependabot/npm_and_yarn/samples/socket.io-2.4.1 branchMarch 10, 2021 12:28
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependenciesPull requests that update a dependency file
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@codecov-io@rigor789

[8]ページ先頭

©2009-2025 Movatter.jp