Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixed Testing with the sample application(s)#713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
brysem wants to merge2 commits intonativescript-vue:masterfrombrysem:sample_runner

Conversation

brysem
Copy link

@brysembrysem commentedSep 2, 2020
edited
Loading

Purpose:
The instructions forhttps://github.com/nativescript-vue/nativescript-vue/blob/master/CONTRIBUTING.md resulted in non-working sample application making contributing not possible without first fixing things.

Implemenation:
Added back the missing sample-runner, dependencies and changes made for NativeScript 7.*

Testing:
This PR can be tested by cloning the repository and following the instructions fromhttps://github.com/nativescript-vue/nativescript-vue/blob/master/CONTRIBUTING.md

@brysem
Copy link
Author

Fixed a merge conflict with master

@rigor789
Copy link
Member

Thanks for the PR, most of the changes are not required in NS7 - the only piece we can bring back is the sample runner, however I have intentionally removed it, as it wasn't useful at all. With a recent refactor to use theentry.js file as the entry, any sample can be tested, just by changing the import in theentry.js file - without the need to restart the whole build process (much much faster).

The docs/contribution guide should be updated instead.

To get started with the repo:

  1. clone the repository
  2. cd nativescript-vue
  3. yarn - to install dependencies
  4. yarn dev - to build nativescript-vue and nativescript-vue-template-compiler in watch mode
  5. cd samples
  6. ns run <platform> --no-hmr (disabling hmr isn't necessary, but preferred most of the time)

To test a different/new sample:

  1. editentry.js and update therequire('./<sample>') statement to require any of the samples in theapp folder.

@jarmani
Copy link

@rigor789@brysem#751 only update the doc and should replace this one if you are ok with it.

@rigor789
Copy link
Member

Thanks for the PR, but closing this - as the removal was intentional and#751 addressed the missing documentation.

@brysembrysem deleted the sample_runner branchNovember 25, 2020 13:43
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@brysem@rigor789@jarmani

[8]ページ先頭

©2009-2025 Movatter.jp