Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork246
Fixed Testing with the sample application(s)#713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Fixed a merge conflict with master |
Thanks for the PR, most of the changes are not required in NS7 - the only piece we can bring back is the sample runner, however I have intentionally removed it, as it wasn't useful at all. With a recent refactor to use the The docs/contribution guide should be updated instead. To get started with the repo:
To test a different/new sample:
|
jarmani commentedNov 21, 2020
Thanks for the PR, but closing this - as the removal was intentional and#751 addressed the missing documentation. |
Uh oh!
There was an error while loading.Please reload this page.
Purpose:
The instructions forhttps://github.com/nativescript-vue/nativescript-vue/blob/master/CONTRIBUTING.md resulted in non-working sample application making contributing not possible without first fixing things.
Implemenation:
Added back the missing sample-runner, dependencies and changes made for NativeScript 7.*
Testing:
This PR can be tested by cloning the repository and following the instructions fromhttps://github.com/nativescript-vue/nativescript-vue/blob/master/CONTRIBUTING.md