Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix rollup problem not exporting Vue as the default element. So using NS-vue from TS is harder#301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
rigor789 merged 1 commit intomasterfromfix-typescript-default-issue
Aug 8, 2018

Conversation

msaelices
Copy link

Probably there is a more elegant issue, but I'm not a roll-up expert.

See#300.

@codecov-io
Copy link

Codecov Report

Merging#301 intomaster willdecrease coverage by0.01%.
The diff coverage is0%.

Impacted file tree graph

@@            Coverage Diff             @@##           master     #301      +/-   ##==========================================- Coverage   14.23%   14.22%   -0.02%==========================================  Files          41       41                Lines        1145     1146       +1       Branches      269      269              ==========================================  Hits          163      163- Misses        982      983       +1
Impacted FilesCoverage Δ
platform/nativescript/framework.js0% <0%> (ø)⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update259640e...3254994. Read thecomment docs.

@championswimmer
Copy link
Contributor

errr you can just useesModuleInterop: true in your tsconfig.json :D

@championswimmer
Copy link
Contributor

@msaelices
Copy link
Author

msaelices commentedAug 8, 2018•
edited
Loading

@championswimmer it does not works for me. I've added these lines:

        "allowSyntheticDefaultImports": true,        "esModuleInterop": true,        "importHelpers": true,

but when I put thismain.js code:

import Vue from 'nativescript-vue'import Foo from 'nativescript-foo'Vue.use(Foo)

I receive this error:

System.err: Error calling module function System.err: TypeError: Cannot read property 'use' of undefined...

@msaelices
Copy link
Author

msaelices commentedAug 8, 2018•
edited
Loading

@championswimmer BTW, I think the dirty fix is better because is universal. I mean, it does not depend on the developer's webpack configuration. It will makeimport Vue from 'nativescript-vue' work always.

CC/@rigor789

@rigor789rigor789 merged commit7e39039 intomasterAug 8, 2018
@rigor789rigor789 deleted the fix-typescript-default-issue branchDecember 5, 2022 17:21
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@rigor789rigor789Awaiting requested review from rigor789

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@msaelices@codecov-io@championswimmer@rigor789
[8]ページ先頭
©2009-2025 Movatter.jp