Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork261
fix: hmr not working on child navigation#1105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes fromall commits
Commits
Show all changes
8 commits Select commitHold shift + click to select a range
b85d523 fix: loads on ios26
sitefinitysteve47918dc fix: hmr not working on navigated pages
sitefinitysteve7c7a57e fix: move loader back to default
sitefinitysteve7a07450 Merge pull request #1 from sitefinitysteve/simple-test
sitefinitysteve04397ac fix: version bump
sitefinitysteveb89dba5 Merge pull request #2 from sitefinitysteve/simple-test
sitefinitysteve8e53a10 chore: restore yarn lockfile
rigor789d299b07 chore: cleanup
rigor789File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
8 changes: 5 additions & 3 deletionsdemo/package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletionsdemo/src/components/HMRTest.vue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| <template> | ||
| <Page> | ||
| <StackLayout> | ||
| <Label | ||
| text="nativescript-vue/demo" | ||
| fontSize="32" | ||
| fontWeight="bold" | ||
| padding="20" | ||
| color="#4CAF50" | ||
| /> | ||
| <Label | ||
| text="Hello World from HMRTest - nativescript-vue Demo" | ||
| fontSize="24" | ||
| padding="20" | ||
| /> | ||
| <Label | ||
| text="Edit this text to test HMR in Demo" | ||
| fontSize="16" | ||
| padding="20" | ||
| /> | ||
| </StackLayout> | ||
| </Page> | ||
| </template> | ||
| <script setup lang="ts"> | ||
| import { onMounted } from 'nativescript-vue'; | ||
| onMounted(() => { | ||
| console.log('HMRTest component mounted - Demo'); | ||
| }); | ||
| </script> |
24 changes: 24 additions & 0 deletionsdemo/src/components/HMRTestLoader.vue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| <template> | ||
| <Frame> | ||
| <Page> | ||
| <Label text="Loading..." /> | ||
| </Page> | ||
| </Frame> | ||
| </template> | ||
| <script setup lang="ts"> | ||
| import { onMounted, $navigateTo } from 'nativescript-vue'; | ||
| import HMRTest from './HMRTest.vue'; | ||
| onMounted(() => { | ||
| console.log('HMRTestLoader mounted'); | ||
| setTimeout(() => { | ||
| console.log('Navigating to HMRTest'); | ||
| $navigateTo(HMRTest, { | ||
| animated: false, | ||
| clearHistory: true, | ||
| }); | ||
| }, 100); | ||
| }); | ||
| </script> |
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.