Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Cutdown Dependencies#1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
heywhy wants to merge5 commits intonativescript-vue:mainfromheywhy:cutdown-deps
Closed

Conversation

@heywhy
Copy link
Contributor

@heywhyheywhy commentedApr 12, 2023•
edited
Loading

  • reduce dependencies to only@vue/runtime-core
  • improvenativescript.webpack.js
  • update the blank template with necessary dependencies
  • make the blank template work with vscode vue extension by patching tsconfig
  • [navigation] dispose page native view before unmounting component
  • update demo app to a working condition

Misc

I will prefer that the vue team allows one to set the vue library to use for template compilation so that one can do the below:

"vueCompilerOptions" {"target":3,"vueLibrary":"nativescript-vue"}

Or they return@vue/runtime-core in thisfunction instead ofvue.

ndianabasi reacted with thumbs up emoji
@vallemar
Copy link
Contributor

vallemar commentedApr 12, 2023•
edited
Loading

@heywhy would it be ok to return in this linevnode so that everyone hasel or the instance of vue??https://github.com/nativescript-vue/nativescript-vue/pull/1038/files#diff-92b6f52e2c1b302cd9d15133831c595f151215aa1dfda274ff29fbd33d89a9b2R37

@heywhy
Copy link
ContributorAuthor

@heywhy would it be ok to return in this linevnode so that everyone hasel??https://github.com/nativescript-vue/nativescript-vue/pull/1038/files#diff-92b6f52e2c1b302cd9d15133831c595f151215aa1dfda274ff29fbd33d89a9b2R37

Yes, it is ok. I didn't do it that way because I couldn't think of a use case for it. Thinking of your comments here, I don't know if I should close the first PR so as to reduce context switching. 😅

vallemar reacted with laugh emoji

@heywhy
Copy link
ContributorAuthor

I've created a PR on the vue-loader project (vuejs/vue-loader#2038), hopefully this gets merged before the conclusion of this PR so I can take off the module resolution patch.

rigor789 reacted with thumbs up emoji

@rigor789rigor789 mentioned this pull requestMay 17, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@heywhy@vallemar
[8]ページ先頭
©2009-2025 Movatter.jp