Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork245
fix: fallback frame when navigating#948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
i am not sure i understand. if no options.frame is passed and there is no more frame with id |
So when we destroy the 2nd It's a bit weird how we handle this, and the reason we even have the frame |
@rigor789 thanks for the explanation. I get it now! seems good to me |
This handles a case where a frame with a different id might have overridden the previous frame with the same id, but has been unmounted.
/cc@farfromrefug