Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
/n8nPublic

fix(core): Ensure error.message is a string before checking for specific messages#17417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
naXa777 wants to merge1 commit inton8n-io:master
base:master
Choose a base branch
Loading
fromnaXa777:bugfix/17413

Conversation

naXa777
Copy link

@naXa777naXa777 commentedJul 17, 2025•
edited
Loading

Summary

Fix "Workflow validation failed: e.message.includes is not a function" error by ensuringerror.message is a string before calling.includes. This issue occurs during workflow validation, but it's unclear whether the root cause is inn8n orn8n-mcp (workflow-validator.ts).

Added a defensive type check to avoid runtime failures.

Related Linear tickets, Github issues, and Community forum posts

fixes#17413.

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled withrelease/backport (if the PR is an urgent fix that needs to be backported)

@CLAassistant
Copy link

CLAassistant commentedJul 17, 2025•
edited
Loading

CLA assistant check
All committers have signed the CLA.

@naXa777naXa777 changed the titlefix core: Ensure error.message is a string before checking for specific messagesfix(core): Ensure error.message is a string before checking for specific messagesJul 17, 2025
Copy link
Contributor

@cubic-dev-aicubic-dev-aibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

cubic reviewed 9 files and found no issues. Review PR incubic.dev.

@n8n-assistantn8n-assistantbot added communityAuthored by a community member coreEnhancement outside /nodes-base and /editor-ui node/improvementNew feature or request in linearIssue or PR has been created in Linear for internal review labelsJul 17, 2025
@Joffcom
Copy link
Member

Hey@naXa777,

Thanks for the PR, We have created "GHC-3171" as the internal reference to get this reviewed.

One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team.

@Joffcom
Copy link
Member

Hey@naXa777,

Please don't forget to add tests.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@cubic-dev-aicubic-dev-ai[bot]cubic-dev-ai[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
communityAuthored by a community membercoreEnhancement outside /nodes-base and /editor-uiin linearIssue or PR has been created in Linear for internal reviewnode/improvementNew feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Something somewhere crashes when error.message is not a string
3 participants
@naXa777@CLAassistant@Joffcom
[8]ページ先頭
©2009-2025 Movatter.jp