This repository was archived by the owner on Jan 20, 2024. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork146
Fixing TypeError: Invalid calling object in Edge#70
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
kyemelianov approved these changesJul 18, 2018
kyemelianov left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We have the same issue in IE11 after build product version.
IE11 can't use 'btoa' without window context.
It is easy reproduce in IE11:
({ btoa: window.btoa }).btoa('123') - return Error
This was referencedJul 14, 2020
Closed via#150 |
The fix is now released in version 4.3.2. Thank you for the contribution! |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I regret I was not able to reproduce the issue in automated tests. However, in my production project I observed TypeError 'Invalid calling object' in MS Edge when calling btoa. The same issue was raised in several projects, for exampletus/tus-js-client#77. This change fixes the error.