Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
This repository was archived by the owner on Jan 20, 2024. It is now read-only.

Fixes #98: Do not send empty scopes to an auth server#154

Merged
postatum merged 6 commits intomasterfromi98_omit_empty_scopes
Aug 3, 2020

Conversation

postatum
Copy link
Contributor

Fixes#98

@postatumpostatum requested a review fromjstoikoJuly 27, 2020 08:04
Copy link
Contributor

@jstoikojstoiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think we should let the user have control over the value ofscope that is sent to the server. Ifscopes is set to"" or[] then we should send an empty string (that's whatsanitizeScope() currently does). Ifscopes is undefined (not set), then we shouldn't send it at all (that part is what needs to be fixed).

@postatum
Copy link
ContributorAuthor

I think we should let the user have control over the value ofscope that is sent to the server. Ifscopes is set to"" or[] then we should send an empty string (that's whatsanitizeScope() currently does). Ifscopes is undefined (not set), then we shouldn't send it at all (that part is what needs to be fixed).

Reworked.

@postatumpostatum requested a review fromjstoikoJuly 30, 2020 09:49
@postatumpostatum merged commita237644 intomasterAug 3, 2020
@postatumpostatum deleted the i98_omit_empty_scopes branchAugust 3, 2020 07:16
@postatumpostatum mentioned this pull requestAug 3, 2020
clancy-au pushed a commit to digiwise/js-client-oauth2 that referenced this pull requestApr 21, 2021
…ulesoft-labs#154)If `scopes` is set to `""` or `[]` then we should send an empty string.If `scopes` is undefined (not set), then we don't send it at all.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@jstoikojstoikojstoiko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scope parameter should not be sent when undefined
2 participants
@postatum@jstoiko
[8]ページ先頭
©2009-2025 Movatter.jp