Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork246
[code-infra] Update changelog script to use utils from code-infra#2823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
brijeshb42 commentedSep 24, 2025
- I have followed (at least) thePR section of the contributing guide.
pkg-pr-newbot commentedSep 24, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
commit: |
mui-bot commentedSep 24, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Bundle size report
|
netlifybot commentedSep 24, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview forbase-ui ready!
To edit notification comments on pull requests, go to yourNetlify project configuration. |
3eb64f3
to9e0218a
Compare9e0218a
to3a3356d
Compare3a3356d
toa512d4b
Comparec95d68b
to9e25f1a
CompareUh oh!
There was an error while loading.Please reload this page.
request:{ | ||
fetch, | ||
}, | ||
constlatestTaggedVersion=awaitfindLatestTaggedVersion({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Didn't realize before, but is there sufficient overlap betweenfindLatestTaggedVersion
andgetLastCanaryTag
to justify a ahared abstraction?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Somewhat similar in that both fetches tags. ButgetLastCanaryTag
fetches just that one tag whereas the otherone needs to fetch all to determine that latest one.
I don't see a reason to abstract them just yet.
Janpot left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good, few remarks, but nothing blocking
c204fef
intomui:masterUh oh!
There was an error while loading.Please reload this page.