Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Allow parameters in custom test functions#64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@lordjabez
Copy link
Contributor

This is to address issue#63.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You're using a string for44, not an int. This breaks the tests for Python3 and PyPy3 (seehttps://travis-ci.org/msiemens/tinydb/builds/68895961).

@msiemens
Copy link
Owner

There's a tiny mistake in a test, but otherwise it looks good!

@lordjabez
Copy link
ContributorAuthor

Should I just remove that test? I only included the string comparison because there was a similar one for the previous test case.

@lordjabez
Copy link
ContributorAuthor

Ahh, I see the issue now. I'll simply remove the test.

@lordjabezlordjabezforce-pushed thefeature/arbitrary-parameters-for-custom-test branch from235902d to9f55011CompareJune 30, 2015 16:52
msiemens added a commit that referenced this pull requestJul 4, 2015
…r-custom-testAllow parameters in custom test functions
@msiemensmsiemens merged commit10a93cd intomsiemens:masterJul 4, 2015
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lordjabez@msiemens

[8]ページ先頭

©2009-2025 Movatter.jp