Thanks ❤️

This is now published in v4.3.0 🙂

@msiemens

Thanks a lot for merging this intomaster and making new 4.3.0 release, I appreciate it!

After upgrading to new release 95% of TinyDB code works smoothly with mypy and another 5% results in next issues:

• error: Call to untyped function "TinyDB" in typed context [no-untyped-call]
• error: Call to untyped function "Query" in typed context [no-untyped-call]
• error: Argument 1 to "search" of "Table" has incompatible type "QueryInstance"; expected "Query" [arg-type]

Any of these issues are critical for me, so for now I justtype: ignore'd them.

After upgrading to new release 95% of TinyDB code works smoothly with mypy and another 5% results in next issues:

Good to hear that most of the code now passes. Do you have line numbers for the remaining errors?

Do you have line numbers for the remaining errors?

As the errors are in my code, I'm copy-pasting the code (with# type: ignore comments) below,

Call to untyped function "TinyDB" in typed context

withTinyDB(settings.tinydb_path)asdb:# type: ignore[no-untyped-call]        ...

Call to untyped function "Query" in typed context

Q=Query()# type: ignore

Argument 1 to "search" of "Table" has incompatible type "QueryInstance"; expected "Query"

defsearch_stuff(db:TinyDB,*,external_uids:Tuple[uuid.UUID, ...])->Tuple[StuffItem, ...]:returntuple(from_dict(StuffItem,item)foritemindb.table(TABLE_STUFF).search(where(# type: ignore[arg-type]"external_uid"            ).one_of([str(item)foriteminexternal_uids])        )    )

I looked into the type errors again and it turns out that not specifiying the return type on an__init__ method makes it untyped:

if__init__ has no annotated arguments and no return type annotation, it is considered an untyped method:

—https://mypy.readthedocs.io/en/stable/class_basics.html#annotating-init-methods

I've pushed a fix which will be included in the next release.

Argument 1 to "search" of "Table" has incompatible type "QueryInstance"; expected "Query"

Regarding this error it's more complicated as MyPy is technically correct:Query is a subclass ofQueryInstance, not the other way around. Thus a function that expect aQuery object won't acceptQueryInstance objects. But in practice this works becauseQueryInstance has a__call__ method to evaluate itself which is inherited toQuery. I'll have to let this open for now

Just a quick note: TinyDB v4.5.0 now includes a fix for the Query error by providing a protocol for Query-like objects which both Query and QueryInstance implement 🙂