- Notifications
You must be signed in to change notification settings - Fork590
Fix Query class to permit subclass creation#270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ContributorAuthor
othalan commentedJun 28, 2019
The checks seem to be failing because of errors communicating with coveralls, not because of any issue with this change. |
Owner
msiemens commentedJul 3, 2019
That's a good idea, thanks@othalan 🙂 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a subclass of the Query class in order to implement custom queries currently fails because thegetattr method creates a new instance of the Query class using a hard-coded name rather than the type of the current instance. This can easily be fixed by using
type(self)()to create the new class instance.Creating a new subclass of Query is useful in order to simplify code scenarios where custom test functions are frequently used.
This pull request provides both a test and a fix for this problem.