- Notifications
You must be signed in to change notification settings - Fork590
Feat: support user storage proxy for string type doc_id#224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
msiemens left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
One change request, otherwise this should be fine 🙂
tinydb/database.py Outdated
| self._storage=storage | ||
| self._table_name=table_name | ||
| defconstruct_doc(self,key,val): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could we rename this to an internal method and also use something like_new_document(…)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
a new commit for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Awesome! Now you just need to adapt the example in
Lines 617 to 618 ina454998
| defconstruct_doc(self,key,val): | |
| returnDocument(val,key) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
😂
msiemens commentedAug 9, 2018
Thanks for the idea, the contribution and the modifications,@Cologler! I'll try to bundle up a release of TinyDB next week 🙂 |
msiemens commentedAug 20, 2018
I've now released v3.11 🙂 I've also changed the parameter name to |
for#221 .
examples see the added unittest.