Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix 0 capacity issue. now cache_size can be 0#187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@wuarmin
Copy link
Contributor

I encountered a problem while setting cache_size to 0. The result was an unlimited cache because in python "0" evaluates to false. This PR would fix this.

kind regards

@wuarmin
Copy link
ContributorAuthor

@msiemens Do you know why the test-build with Python 2.6 failed?

@msiemens
Copy link
Owner

Thanks for the Pull Request! 🙂

@msiemens Do you know why the test-build with Python 2.6 failed?

This is due to#185 where it's still up to debate whether or not to drop Python 2.6 as our test infrastructure has dropped support for it.

@msiemensmsiemens merged commit3fcbd4c intomsiemens:masterJan 27, 2018
@wuarmin
Copy link
ContributorAuthor

wuarmin commentedJan 27, 2018
edited
Loading

@msiemens All right. I 'll provide another to provide the option to disable cache explicitly. (We talked about it at#179 )

@wuarminwuarmin deleted the fixes/fix_capacity_0_issue branchJanuary 27, 2018 19:11
@msiemens
Copy link
Owner

Actually, I'm just thinking about if the best way to disable the query cache would be to actually use acache_size of 0 and in this case skip the query cache logic or replace the cache with an class that has the same interface/api but doesn't perform any caching. This may make the API a little less nosiy compared to adding a new argument – if we document this properly. What do you think?

eugene-eeo reacted with thumbs up emoji

@wuarmin
Copy link
ContributorAuthor

@msiemens Yes, I think you are right. Defining a cache_size of zero, fullfills the purpose. Another option is not necessary.

@msiemens
Copy link
Owner

This is now released in v3.8.0 🙂

@wuarmin
Copy link
ContributorAuthor

wuarmin commentedMar 3, 2018
edited
Loading

@msiemens
great!
The latest version in python package index is still 3.7.0.
If I want to upgrade I get following message:

CRITICAL:pip.index:Could not find a version that satisfies the requirement tinydb==3.8.0 (from versions: 1.0.0, 1.0.1, 1.1.0, 1.1.1, 1.2.0, 1.3.0, 1.4.0, 2.0.0, 2.0.1, 2.1.0, 2.2.0, 2.2.1, 2.2.2, 2.3.0b0, 2.3.1, 2.3.1.post1, 2.3.1.post2, 2.3.2, 2.4, 3.0.0, 3.1.0, 3.1.1, 3.1.2, 3.1.3, 3.2.0, 3.2.1, 3.2.2, 3.2.3, 3.3.0, 3.3.1, 3.4.0, 3.4.1, 3.5.0, 3.6.0, 3.7.0)

@msiemens
Copy link
Owner

msiemens commentedMar 3, 2018
edited
Loading

Whoops! Forgot to publish it on PyPI, sorry! Should work now 🙂

@wuarmin
Copy link
ContributorAuthor

thanks! 👍 I'm on 3.8.0 😄

msiemens reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wuarmin@msiemens

[8]ページ先頭

©2009-2025 Movatter.jp