- Notifications
You must be signed in to change notification settings - Fork590
Remove absolute imports to support vendoring#142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
tinydb/__init__.py Outdated
| >>> fromtinydb import TinyDB, where | ||
| >>> fromtinydb.storages import MemoryStorage | ||
| >>> from. import TinyDB, where | ||
| >>> from .storages import MemoryStorage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think we should keep the absolute import here as that's what users will usually continue to use. Or am I mistaken?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oh, yes you are right. Sorry about that.
msiemens commentedJun 22, 2017
One small nit with the docstring, otherwise looks good to me! |
msiemens commentedJun 23, 2017
Merged, thanks! I'll try to find to release a new version of TinyDB next week :) |
msiemens commentedJun 27, 2017
BTW, I've just released v3.3.1 which includes this pull request :) |
Hi folks,
Thanks for this amazing project! I'm looking to bundle tinydb with another software library but couldn't due to the global references to
tinydbin import statements.This PR makes all imports relative, so that you can now do this.
Let me know if there are any issues.