Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork68
Add API for AccessToken#199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
mrmn2 commentedNov 18, 2025
Hi, glad to have you back. I thought I lost you because of my inactivity. As promised my break is over. Since I thought you do not want to continue I did some research for taking over this issue. I now think that using the default DRF token authentication is sufficient for PdfDing, as every user will only have one token at a time. There is no real need for an extra dependency. If you are annoyed by yet another change in requirements I can totally understand you and will merge your PR and change the authentication myself. Of course if you want to do it I am also happy. Just let me know which way you want to proceed. |
wh0th3h3llam1 commentedNov 19, 2025
so based on what you're suggesting, user will have only one token (DRF token). but how will he generate the token? using UI only? if yes. then ig we wont need any extra model or serializers or these endpoints. also, there will only be option to create/delete token by default. if we wanna rotate, we might need custom logic and no, i'm not annoyed by these changes. it totally fine. |
mrmn2 commentedNov 19, 2025
Yes, users can only generate / rotate the token via the UI. I think this enough for this project. It will also make things simpler and thus easier to maintain. Many other popular self-hosted projects do it like this as well. I am relieved to hear that you are not fed up! |
applied changes from conversation in#170 ,
namecan be updated from API.