Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add API for AccessToken#199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
wh0th3h3llam1 wants to merge6 commits intomrmn2:master
base:master
Choose a base branch
Loading
fromwh0th3h3llam1:feat/api

Conversation

@wh0th3h3llam1
Copy link

  • Add AccessToken model
  • Create API for AccessToken
  • Add tests

applied changes from conversation in#170 ,

  1. onlyname can be updated from API.
  2. Kepst serializers to be reused in future APIs
  3. update tests

phanirithvij reacted with thumbs up emoji
@mrmn2
Copy link
Owner

Hi, glad to have you back. I thought I lost you because of my inactivity. As promised my break is over.

Since I thought you do not want to continue I did some research for taking over this issue. I now think that using the default DRF token authentication is sufficient for PdfDing, as every user will only have one token at a time. There is no real need for an extra dependency.

If you are annoyed by yet another change in requirements I can totally understand you and will merge your PR and change the authentication myself. Of course if you want to do it I am also happy. Just let me know which way you want to proceed.

@wh0th3h3llam1
Copy link
Author

@mrmn2

so based on what you're suggesting, user will have only one token (DRF token). but how will he generate the token? using UI only? if yes. then ig we wont need any extra model or serializers or these endpoints. also, there will only be option to create/delete token by default. if we wanna rotate, we might need custom logic

and no, i'm not annoyed by these changes. it totally fine.

@mrmn2
Copy link
Owner

Yes, users can only generate / rotate the token via the UI. I think this enough for this project. It will also make things simpler and thus easier to maintain. Many other popular self-hosted projects do it like this as well.

I am relieved to hear that you are not fed up!

phanirithvij reacted with eyes emoji

@wh0th3h3llam1wh0th3h3llam1 marked this pull request as draftNovember 25, 2025 16:06
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@mrmn2mrmn2Awaiting requested review from mrmn2mrmn2 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wh0th3h3llam1@mrmn2

[8]ページ先頭

©2009-2025 Movatter.jp