- Notifications
You must be signed in to change notification settings - Fork74
feat: Support for opt-in caching#268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
simon-paris wants to merge1 commit intomrmckeb:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
+32 −3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Hi@mrmckeb, would you be able to review this? |
Hi@simon-paris, sorry for the long delay. I changed jobs and moved cities over the last few months and didn't get much free time for open source. I'll take a look at this with some other changes this weekend hopefully! :) |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds caching, which is off by default and enabled using
{caching: "always"}. It works by mapping from snapshots provided by typescript to snapshots generated by the plugin using a WeakMap.The
cachingoption allows"always" | "never". I chose to use a union instead of a bool to 1) later support for a third "only when safe" or "only when supported" option, and 2) to help indicate that it might be too aggressive since "always" sounds stronger than true.Fixes#215
cc@jsliang