Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: goToDefinition support default classes#260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
qyzzzz wants to merge1 commit intomrmckeb:main
base:main
Choose a base branch
Loading
fromqyzzzz:main

Conversation

qyzzzz
Copy link
Contributor

@qyzzzzqyzzzz commentedFeb 27, 2024
edited
Loading

It seems that goToDefinition does not support jumping to the definition ofimport s from "a.scss'; s['xxx']. This is because the variable declaration is only added to appropriate dts lines indtsLines.
To resolve this issue, the proposed solution in this PR is to modify declare property by using an interface to define the property. This will allow nameExports and property to be on the same line, enabling goToDefinition to jump to the correct line number. Of course, invalid nameExports will still be filtered out.

roshal reacted with thumbs up emoji
@astrodelete
Copy link

Hello,
Is this by any chance related to thisissue we encountered in Webstorm?

@mrmckeb
Copy link
Owner

Hi@qyzzzz, this looks like a very interesting change. This also looks like a very big change and unfortunately I'm away at the moment, but will try to look in a week or so when I'm back.

Can you confirm that you've tested that everything still works for users with other configurations than yours? It's unfortunately quite hard to test, you need to do it manually.

@mrmckebmrmckeb self-assigned thisMar 21, 2024
@qyzzzz
Copy link
ContributorAuthor

qyzzzz commentedMar 26, 2024
edited
Loading

Hi@mrmckeb, sorry for delay here.
I have determined the feasibility of this solution by reviewing and comparing the unit test snapshots in your project.
Additionally, I have created a separate project for manual effect testing. In this round of modifications, I primarily examined the impact of these changes on the goToDefinition, namedExports, and allowUnknownClassnames options.
https://github.com/qyzzzz/typescript-plugin-css-modules-goToDefinition-reproduction
Unfortunately, I am currently using VSCode and have not tested with Webstorm.😅

roshal reacted with thumbs up emoji

@mrmckebmrmckeb added this to thev6.0.0 milestoneOct 10, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees

@mrmckebmrmckeb

Labels
None yet
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging this pull request may close these issues.

3 participants
@qyzzzz@astrodelete@mrmckeb

[8]ページ先頭

©2009-2025 Movatter.jp