- Notifications
You must be signed in to change notification settings - Fork74
feat: goToDefinition support default classes#260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
astrodelete commentedMar 20, 2024
Hello, |
Hi@qyzzzz, this looks like a very interesting change. This also looks like a very big change and unfortunately I'm away at the moment, but will try to look in a week or so when I'm back. Can you confirm that you've tested that everything still works for users with other configurations than yours? It's unfortunately quite hard to test, you need to do it manually. |
qyzzzz commentedMar 26, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hi@mrmckeb, sorry for delay here. |
Uh oh!
There was an error while loading.Please reload this page.
It seems that goToDefinition does not support jumping to the definition of
import s from "a.scss'; s['xxx']
. This is because the variable declaration is only added to appropriate dts lines indtsLines
.To resolve this issue, the proposed solution in this PR is to modify declare property by using an interface to define the property. This will allow nameExports and property to be on the same line, enabling goToDefinition to jump to the correct line number. Of course, invalid nameExports will still be filtered out.