This change generalizes "module resolution with failed lookup locations" so that it works for newer implementations of the typescript language server, which provide such information in the response forresolveModuleNameLiterals, rather than implementing a separategetResolvedModuleWithFailedLookupLocationsFromCache.

Tested locally in a project using Typescript 5 and path aliases, and imports like:

import{editorContainer,tableOfContentsContainer,}from"@/components/app.module.css"

which were failing before this change now successfully show type information and support "Go to Definition", etc.

Fix module resolution for non-relative paths in newer tsserver implem…

714eb23

…entations

Copy link

ContributorAuthor

smoores-dev commentedJun 22, 2023

Hey@mrmckeb! I imagine you've got a ton of other stuff going on, but let me know if you have a chance to take a look at this any time soon! I'd love to get your thoughts. Thanks so much for all of your work on this plugin!

Copy link

LoiLock commentedSep 5, 2023

Any updates?

Copy link

ContributorAuthor

smoores-dev commentedSep 21, 2023

Hey@mrmckeb! I just wanted to check in and see whether you might have a chance to take a look at this PR sometime soon!

mrmckeb approved these changes

Sep 22, 2023

View reviewed changes

Copy link

Owner

mrmckeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@smoores-dev - this looks great to me. Sorry for the very slow turnaround, I try to check in once every 2-3 weeks (unless there's a critical issue) but had a bit more going on recently.

mrmckeb changed the title~~Fix module resolution for non-relative paths in newer tsserver implementations~~fix: update module resolution for non-relative paths

Sep 22, 2023

mrmckeb closed this

Sep 22, 2023

mrmckeb reopened this

Sep 22, 2023

Copy link

Owner

mrmckeb commentedSep 22, 2023

Closing and reopening to trigger tests, etc.

mrmckeb merged commite21ae36 intomrmckeb:main

Sep 22, 2023

Copy link

Owner

mrmckeb commentedSep 25, 2023

I plan to get this out in the next day or two - I also need to set up automatic releases for this repo.

Copy link

Owner

mrmckeb commentedOct 16, 2023

Sorry this took so long. Released:
https://github.com/mrmckeb/typescript-plugin-css-modules/releases/tag/v5.0.2

smoores-dev deleted the typescript-5-paths-support branch

October 16, 2023 16:08

sungik-choi added a commit to sungik-choi/bezier-react that referenced this pull request

Dec 12, 2023