- Notifications
You must be signed in to change notification settings - Fork74
fix: check if file exists before processing#218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This prevents the VSCode plugin from crashing when an imported css/scss/etc... file does not exist.
mrmckeb previously approved these changesApr 10, 2023
Thanks for this, and sorry for the slow turnaround. |
mrmckeb previously approved these changesApr 10, 2023
mrmckeb approved these changesApr 10, 2023
@adam-26, as there was a type issue I moved the check up to the plugin root, so we don't call the function if the file doesn't exist. Thanks again for your help! |
calvellido referenced this pull request in arrow-kt/arrow-websiteApr 10, 2023
[](https://renovatebot.com)This PR contains the following updates:| Package | Change | Age | Adoption | Passing | Confidence ||---|---|---|---|---|---||[typescript-plugin-css-modules](https://togithub.com/mrmckeb/typescript-plugin-css-modules)| [`5.0.0` ->`5.0.1`](https://renovatebot.com/diffs/npm/typescript-plugin-css-modules/5.0.0/5.0.1)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|---### Release Notes<details><summary>mrmckeb/typescript-plugin-css-modules</summary>###[`v5.0.1`](https://togithub.com/mrmckeb/typescript-plugin-css-modules/releases/tag/v5.0.1)[CompareSource](https://togithub.com/mrmckeb/typescript-plugin-css-modules/compare/v5.0.0...v5.0.1)**Bug fixes:**- fix: check if file exists before processing([@​adam-26](https://togithub.com/adam-26),[https://github.com/mrmckeb/typescript-plugin-css-modules/pull/218](https://togithub.com/mrmckeb/typescript-plugin-css-modules/pull/218)).**New contributors:**- [@​adam-26](https://togithub.com/adam-26) made their firstcontribution in[https://github.com/mrmckeb/typescript-plugin-css-modules/pull/218](https://togithub.com/mrmckeb/typescript-plugin-css-modules/pull/218).**Full changelog**:mrmckeb/typescript-plugin-css-modules@v5.0.0...v5.0.1</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined),Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once youare satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this updateagain.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR has been generated by [MendRenovate](https://www.mend.io/free-developer-tools/renovate/). Viewrepository job log[here](https://app.renovatebot.com/dashboard#github/arrow-kt/arrow-website).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS40MC4wIiwidXBkYXRlZEluVmVyIjoiMzUuNDAuMCJ9-->Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
%5d(https%3a%2f%2frenovatebot.com){kind=link}
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This prevents the VSCode plugin from crashing when an imported css/scss/etc... file does not exist.
A more elegant solution would be to check if the file exists before the
readFileSynccall.Will alsofix:#216