Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add support for TypeScript 5.x#211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mrmckeb merged 1 commit intomainfrom196-ts-5-compatibility
Mar 11, 2023
Merged

Conversation

mrmckeb
Copy link
Owner

This PR adds support for TypeScript 5.x.

Once merged, this will be released as a beta for further testing.

@mrmckebmrmckeb linked an issueMar 11, 2023 that may beclosed by this pull request
@mrmckebmrmckebforce-pushed the196-ts-5-compatibility branch from9792959 tob515389CompareMarch 11, 2023 07:32
@mrmckebmrmckeb merged commitaa18204 intomainMar 11, 2023
@mrmckebmrmckeb deleted the 196-ts-5-compatibility branchMarch 11, 2023 07:34
},
});

const languageService = createLanguageService(languageServiceHostProxy);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should this be using the ts parameter? If tsserver is run via VS Code, it may not match the version in node_modules.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(Generally I'd suggesttype importing only for plugins to avoid this mismatch)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Also, you probably only want to import from tsserverlibrary, as it's a different bundle entirely.

@jakebaileyjakebailey mentioned this pull requestMar 21, 2023
calvellido referenced this pull request in arrow-kt/arrow-websiteMar 22, 2023
[![MendRenovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)This PR contains the following updates:| Package | Change | Age | Adoption | Passing | Confidence ||---|---|---|---|---|---||[typescript-plugin-css-modules](https://togithub.com/mrmckeb/typescript-plugin-css-modules)| [`4.2.3` ->`5.0.0`](https://renovatebot.com/diffs/npm/typescript-plugin-css-modules/4.2.3/5.0.0)|[![age](https://badges.renovateapi.com/packages/npm/typescript-plugin-css-modules/5.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)|[![adoption](https://badges.renovateapi.com/packages/npm/typescript-plugin-css-modules/5.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)|[![passing](https://badges.renovateapi.com/packages/npm/typescript-plugin-css-modules/5.0.0/compatibility-slim/4.2.3)](https://docs.renovatebot.com/merge-confidence/)|[![confidence](https://badges.renovateapi.com/packages/npm/typescript-plugin-css-modules/5.0.0/confidence-slim/4.2.3)](https://docs.renovatebot.com/merge-confidence/)|---### Release Notes<details><summary>mrmckeb/typescript-plugin-css-modules</summary>###[`v5.0.0`](https://togithub.com/mrmckeb/typescript-plugin-css-modules/releases/tag/v5.0.0)[CompareSource](https://togithub.com/mrmckeb/typescript-plugin-css-modules/compare/v4.2.3...v5.0.0)**Breaking changes:**- TypeScript 4.x is now the minimum supported version([@&#8203;mrmckeb](https://togithub.com/mrmckeb),[https://github.com/mrmckeb/typescript-plugin-css-modules/pull/211](https://togithub.com/mrmckeb/typescript-plugin-css-modules/pull/211)).**New features:**- Added support for TypeScript 5.x([@&#8203;mrmckeb](https://togithub.com/mrmckeb),[https://github.com/mrmckeb/typescript-plugin-css-modules/pull/211](https://togithub.com/mrmckeb/typescript-plugin-css-modules/pull/211)).**Bug fixes:**- Fixed use of non-init provided TypeScript lib and move to consistent`server` imports ([@&#8203;jakebailey](https://togithub.com/jakebailey),[https://github.com/mrmckeb/typescript-plugin-css-modules/pull/213](https://togithub.com/mrmckeb/typescript-plugin-css-modules/pull/213)).**New contributors:**- [@&#8203;jakebailey](https://togithub.com/jakebailey) made their firstcontribution in[https://github.com/mrmckeb/typescript-plugin-css-modules/pull/213](https://togithub.com/mrmckeb/typescript-plugin-css-modules/pull/213).**Full changelog:**mrmckeb/typescript-plugin-css-modules@v4.2.3...v5.0.0</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined),Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once youare satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this updateagain.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR has been generated by [MendRenovate](https://www.mend.io/free-developer-tools/renovate/). Viewrepository job log[here](https://app.renovatebot.com/dashboard#github/arrow-kt/arrow-website).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNC4yIiwidXBkYXRlZEluVmVyIjoiMzUuMTQuMiJ9-->Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jakebaileyjakebaileyjakebailey left review comments

@lianapachelianapachelianapache approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeScript 5.0 support
3 participants
@mrmckeb@jakebailey@lianapache

[8]ページ先頭

©2009-2025 Movatter.jp