- Notifications
You must be signed in to change notification settings - Fork74
fix: add and test support forcomposes
in CSS modules#210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
mrmckeb merged 1 commit intomainfrom207-classes-with-composes-break-the-exports-for-the-pluginMar 11, 2023
Merged
fix: add and test support forcomposes
in CSS modules#210
mrmckeb merged 1 commit intomainfrom207-classes-with-composes-break-the-exports-for-the-pluginMar 11, 2023
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
lianapache previously approved these changesMar 11, 2023
680b39e
to206ba32
Comparelianapache approved these changesMar 11, 2023
calvellido referenced this pull request in arrow-kt/arrow-websiteMar 13, 2023
[](https://renovatebot.com)This PR contains the following updates:| Package | Change | Age | Adoption | Passing | Confidence ||---|---|---|---|---|---||[typescript-plugin-css-modules](https://togithub.com/mrmckeb/typescript-plugin-css-modules)| [`4.2.2` ->`4.2.3`](https://renovatebot.com/diffs/npm/typescript-plugin-css-modules/4.2.2/4.2.3)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|---### Release Notes<details><summary>mrmckeb/typescript-plugin-css-modules</summary>###[`v4.2.3`](https://togithub.com/mrmckeb/typescript-plugin-css-modules/releases/tag/v4.2.3)[CompareSource](https://togithub.com/mrmckeb/typescript-plugin-css-modules/compare/v4.2.2...v4.2.3)**Bug fixes:**- Fixed a bug where named exports were dropped when `goToDefinition` isenabled ([@​mrmckeb](https://togithub.com/mrmckeb),[https://github.com/mrmckeb/typescript-plugin-css-modules/pull/208](https://togithub.com/mrmckeb/typescript-plugin-css-modules/pull/208)).- Fixed support for `composes` in CSS modules([@​mrmckeb](https://togithub.com/mrmckeb),[https://github.com/mrmckeb/typescript-plugin-css-modules/pull/210](https://togithub.com/mrmckeb/typescript-plugin-css-modules/pull/210)).**Full changelog**:mrmckeb/typescript-plugin-css-modules@v4.2.2...v4.2.3</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined),Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once youare satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this updateagain.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR has been generated by [MendRenovate](https://www.mend.io/free-developer-tools/renovate/). Viewrepository job log[here](https://app.renovatebot.com/dashboard#github/arrow-kt/arrow-website).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNjAuMCIsInVwZGF0ZWRJblZlciI6IjM0LjE2MC4wIn0=-->Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were no tests for this previously, so I'm not sure if this was working and was broken by the last refactor - but this is now resolved.