Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork35.9k
Preparation for dispatchWorkgroupsIndirect#31026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Spiri0 wants to merge3 commits intomrdoob:devChoose a base branch fromSpiri0:dispatchWorkgroupsIndirect
base:dev
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
github-actionsbot commentedApr 29, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue:#30982
This is the preparation for
dispatchWorkgroupsIndirect
This allows an indirect buffer to be passed to the compute node, similar to the geometry. This indirect buffer has nothing to do with drawIndirect!
However, it is a very similar functionality to drawIndirect. This indirect buffer can be used to dynamically change the workgroup size with the GPU. This functionality can basically be used with any compute shader independent of drawIndirect.
In itself, the matter is quite simple, because the buffer simply needs to be passed to the passEncoderGPU, like this:
However, I have not yet found the right place for the intermediate step in the compute routine that would actually retrieve the GPUBuffer with
this.get( indirect )
But that would be all there is to it. Fortunately, this functionality is much less complex, since the most important part is already present with the IndirectStorageBufferAttribute.
Here's a pure webgpu example. You can see the application in the line: 180
https://codepen.io/Spiri0/pen/zxxdgYZ
The triangle is normally RGB colored. The compute shader executed with dispatchWorkgroupsIndirect makes it green