- Notifications
You must be signed in to change notification settings - Fork77
Rename and documentU2FAPDUHeader and fix Nc=0 (main branch)#191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
* Fixes an issue where Lc bytes would be included when Nc = 0 (zero command data length). This is incorrect in ISO 7816-4:2005 (which FIDO v1.1 and v1.2 correctly describe). This affected the `GetVersion` command; and tests have been updated accordingly.* Renames `U2FAPDUHeader` to `CTAP1RequestAPDU`. Using the name "CTAP1" rather than "U2F" follows the convention put forward in FIDO v2.x specs, which avoids confusion like "U2Fv2" = "CTAP1". The previous implementation wasn't just "a header", but rather the complete APDU.* Renames `FidoDevice::send_apdu` to `FidoDevice::send_ctap1`. This makes it more like `RequestCtap2`, and avoids confusion later on when adding support for CTAP2 over NFC (which still uses ISO 7816-4 APDUs).* Documents and add tests for `CTAP1RequestAPDU`, explaining the confusing state of affairs.
rmartinho approved these changesOct 11, 2022
Contributor
rmartinho left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks!
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses#190 on the
mainbranch. The issues described here also affect thectap2-2021branch (see#189).Fixes an issue where Lc bytes would be included when Nc = 0 (zero command data length). This is incorrect in ISO 7816-4:2005 (which FIDO v1.1 and v1.2 correctly describe).
This affected the
GetVersioncommand; and tests have been updated accordingly.Renames
U2FAPDUHeadertoCTAP1RequestAPDU.Using the name "CTAP1" rather than "U2F" follows the convention put forward in FIDO v2.x specs, which avoids confusion like "U2Fv2" = "CTAP1".
The previous implementation wasn't just "a header", but rather the complete APDU.
Renames
FidoDevice::send_apdutoFidoDevice::send_ctap1. This makes it more likeRequestCtap2, and avoids confusion later on when adding support for CTAP2 over NFC (which still uses ISO 7816-4 APDUs).Documents and add tests for
CTAP1RequestAPDU, explaining the confusing state of affairs.